-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify Weston server decoration to look better in WSLg #129
base: working
Are you sure you want to change the base?
Conversation
@PetervdPerk please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
While I haven't looked detail yet, but I think we need to have window frame region to grab window resize bar, so I guess you need to have some transparent region around RDP window. For example, there is an option to disable remoting window shadow from Linux side (since eventually we want to add by Windows host), so if not remoting shadow, the resize region is too small to grab, especially Wayland native app, thus transparent area is added by weston-mirror/libweston/backend-rdp/rdprail.c Line 1508 in 3ff4250
|
The resizing problem seems to be related to xwayland and not the RDP window. |
@ManMower, would you please help us on the upstream MR @PetervdPerk is referring? Also, I hope we can clean up those of magic numbers for UI theme, at least, have some # define, or even better to encapsuled in theme, so it makes easier to switch theme, is this something interested in upstream? thanks! |
If an application doesn't have Client-side decoration (CSD), it doesn't look nice in Windows 11 with WSLg due to weston's default fallback decoration.
This patch removes the border and makes the task bar a bit more modern.
Open issue:
Resize doesn't work properly through WSLg, it does work fine under native Ubuntu 20.04 and the RDP backend.
But I think it has to do something on how WSLg extracts the windows from the RDP sesion.